Repository navigation
Fix/mock camera - #389
Open
kimichenn wants to merge 4 commits into
Open
Fix/mock camera#389kimichenn wants to merge 4 commits into
kimichenn wants to merge 4 commits into
Conversation
kimichenn
marked this pull request as ready for review
October 23, 2026 01:57
AskewParity
approved these changes
Oct 24, 2026
AskewParity
left a comment
AskewParity
left a comment
Contributor
There was a problem hiding this comment.
I think these are good changes. I didn't even realize we failed to provide not-stolen with FOV.
However, I'd prefer if you explained what "fix math" was.
In the math sections there are 2 changes:
- Remove unused variables
- Use
atan2instead of manually doing the math
I don't know if there were any bugs when we did the math ourselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of pinging
/from not-stolen and getting a 404, we ping the/healthroute now, which returns 200. Also fixed some math to make detection location much more accurate.