Skip to content

Integrate startup profiling and harden onDone CI fixture - #154

Merged
trvon merged 8 commits into
masterfrom
fix/master-profiling-ci
Oct 14, 2026
Merged

trvon merged 8 commits into
masterfrom
fix/master-profiling-ci

Conversation

@trvon

@trvon trvon commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

Changes

Integrate #152 into master, preserving its published ancestry. #152 merged into chore/stack-next-release-deps; master 85a9465 does not contain those changes. Signed integration commit b0ce974 has parents 85a9465 and fdbdf90; its tree exactly matches published b820312.

Harden two additional positive onDone fixtures in test/index.test.ts. Wait for the matching monitor's terminal receipt and actual message delivery instead of a fixed 500 ms sleep. Add a delayed-child case. Retain exact-one, outcome, output-safety, and 10-second deadline assertions. Production monitor/wake code is unchanged relative to #152.

Evidence

Master CI 38562237909 passed Linux and failed Windows's custom onDone wake assertion: expected one message, observed zero. Terminal/delivery readiness was not reported; the original Windows cause remains unproved.

Before repair, the owned sleep 1; echo 'monitor done' case failed at the same message assertion using the old wait strategy. Its recorded state had no terminal receipt or delivery yet. Four nearby controls passed. After repair, the same five cases pass. This is fixture-readiness hardening, not a demonstrated production defect.

The integration retains #152's shared index/API bundle, external host packages and Node builtins, factory-time RPC, first-request schemas, factory-return admission, and bounded worker profiling. Compiled index/chunk hashes still match #152's measured bundle.

Validation

  • Serialized, source-fenced local gate: lint, strict production/dev typecheck, 82 files / 1,286 tests, 11 property files / 30 tests, enforced coverage, build, package/public types, audit, and diff check; all pass. Two established lint warnings; no new warnings. Property/coverage campaigns overlap the full suite.
  • Actual Node 22.19.0: seven files / 155 tests, 73-file package/public imports, SDK 1.2 startup smoke with nine timing children and three separate CPU-profile children; physical exits and affirmative factory receipts pass.
  • Actual Node 22 property-worker smoke: seed 155921, three runs per overlapping lifecycle/consumer variant, complete source manifest, successful physical child, retained profile/checksum; unknown counters remain null.
  • Narrow independent source review found no concrete blocker. It did not run tests or builds and is not Windows attestation.

Hosted CI 38573211125 passes at exact head 7d3412127c592b2a4f323ba2f78e46b26271da55: Node 22.23.3, Linux 1,286 passed; Windows 1,279 passed / 7 skipped; both build and package checks pass. CodeQL 38573206627 passes at the same head. Windows POSIX skips are not native passes.

trvon and others added 7 commits October 13, 2026 23:10
Reduce the internal module graph without deferring RPC, tool registration, or recovery. Keep host packages external and index/API runtime modules shared.

Add receipt-aware paired startup measurements and bounded property-worker CPU profiles with campaign provenance, failure retention, source identity, and explicit unknown counters.
The mismatched minimized path executed zero cases, correctly reported as incomplete despite a passing test. Use the seed/path combination observed to execute 100 cases and retain a worker profile.
perf: reduce startup module graph and profile fuzz workers
Comment thread benchmarks/profile-startup.ts Fixed
…zation'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@trvon
trvon merged commit a448d4f into master Oct 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants