Repository navigation
feat(app): adopt Neo design system and EvilCharts - #262
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring the CRM onto Neo’s design system and replace dashboard charts with EvilCharts.
Before:
711c909(main). After:0a0cf9b(this PR). Both production builds use the same local seeded data.Desktop: 1440 × 900. Phone: 390 × 844.
Workflow videos
Both MP4 recordings use 1440 × 900 at 60 fps.
The before recording lasts 8.3 seconds. The after recording lasts 10.1 seconds.
The after recording also shows the new record navigation arrows.
workflow-before.mp4
workflow-after.mp4
Problem
CRM screens use inconsistent spacing, controls, icons, loading states, and metadata separators.
Record sheets need reliable navigation and motion.
Charts need exact reporting-currency values and keyboard access.
UX Flow
Solution
Keep CRM’s Radix contracts and centralize Neo tokens, components, motion, icons, and responsive patterns in
packages/ui.Use skeletons for page loads and guards for unsaved creation forms and uncopied API keys.
Remove decorative bullet separators and em dashes from interface copy.
Use EvilCharts’ ECharts canvas provider for dashboard charts.
Keep exact money formatting, hidden data tables, keyboard tooltips, atomic announcements, reduced motion, and forced-colors focus.
Record totals exclude stale reporting-currency conversions and archived pipeline records.
Dependency remediation updates Better Auth and its plugins together to 1.7.7.
It patches the parser, upload, URI, query, HTTP-client, and validation dependencies without suppressing advisories.
Slack linking uses the current social API and retains the registered callback URL through a guarded redirect.
Mailbox refresh selects the local account row ID. Regression tests cover both contracts.
The frozen lockfile audit reports zero vulnerabilities.
Validation
The initial design push uses the documented WIP exception. The dependency-fix push runs all normal hooks.
Unrelated local
.tripwire/andtripwire.tsfiles stay outside this commit.Issues
RISK — Audit findings are patched. The security update changes Microsoft account identifiers.
Fix: follow the verified Microsoft identifier migration in
docs/setup.mdbefore deployment.RISK — The earlier task-retirement limit failure does not reproduce in the current full runs.
Fix: not changed. Keep the existing regression test for database-plan-dependent failures.
RISK — Lint reports six existing barrel-export warnings in unchanged database and telemetry modules.
Fix: not done. Lint exits successfully.
UNKNOWN — Native VoiceOver speech remains unverified.
Fix: run a manual speech check on a host that keeps VoiceOver active.
UNKNOWN — Native Windows High Contrast and speech remain unverified.
Fix: run a manual check on Windows. Chromium forced-colors emulation passes.
BROKEN — The automatic PR workflow lacks GitHub permission to create pull requests.
Fix: this draft uses the authenticated CLI and the repository-generated title. Repository automation still needs permission.