Repository navigation
Add hollowpositioningarmtube model contract - #56
Merged
Merged
Conversation
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
hollowpositioningarmtube, a reusable parametric contract for hollow positioning arm tubes used in lamp and camera assemblies. The model supports outside/bore diameters, two straight lengths, a circular bend and optional annular ribs. It describes the installed envelope; wires, mounting fittings and mechanical load ratings remain outside this model.The folder-local schema, parser and typed registration expose
hollowPositioningArmTubeModelPropsSchema,getHollowPositioningArmTubeDimensionsandgetHollowPositioningArmTubeFrame, with correspondingHollowPositioningArmTubetypes. The parameter documentation is indocs/hollowpositioningarmtube.md. Public model names, paths, examples and tests consistently usehollowpositioningarmtube.The paired renderer is jscad-electronics#442, which supplies the three labeled four-view snapshots below and consumes this contract's immutable package preview at
394ffb8. Merge and release this contract before replacing that preview with a stable dependency in the renderer.Validation:
394ffb8; the package preview is published.90-degree bend:
Straight ribbed tube:
Smooth U bend: