Skip to content
This repository was archived by the owner on Sep 23, 2026. It is now read-only.

fix: pin apple/swift-log to 1.13.x so tuist's CLI can adopt the pipe-drainer fix without a swift-log 1.15 migration - #314

Open
pepicrft wants to merge 2 commits into
mainfrom
revert/swift-log-post-0.14.11-bumps
Open

pepicrft wants to merge 2 commits into
mainfrom
revert/swift-log-post-0.14.11-bumps

Conversation

@pepicrft

Copy link
Copy Markdown
Contributor

Summary

Revert the two automated dependency bumps that walked apple/swift-log from 1.13.2 → 1.14.0 (#301) → 1.15.0 (#311). The resulting 0.14.15 release keeps the 0.14.14 pipe-drainer fix from #313 but ships it against apple/swift-log 1.13.x, which is the range tuist's own CLI can consume.

Why

Post-mortem on the sync into tuist/tuist:

  • tuist/tuist's Package.swift intentionally caps apple/swift-log below 1.14. The comment on that cap: "apple/swift-log 1.15 introduced a second overload of Logger's level-specific helpers (with a new error: parameter). With both signatures accepting a Logger.Message positional argument and everything else defaulted, plain call sites like logger.notice(\"...\") are ambiguous."
  • On top of the overload ambiguity, swift-log 1.15 also introduces its own Logger.current computed property, which collides with TuistLogging's existing @TaskLocal public static var current: Logger extension.
  • Both issues mean bumping tuist to Command 0.14.14 is not a one-line change: it's a migration across dozens of call sites plus a rework of the task-local logger, unrelated to the CI VM hang fix that shipped in fix: install pipe drainers synchronously so tuist install stops hanging on 3-vCPU CI VMs #313.

The Command bumps to 1.14 / 1.15 were Renovate keep-current bumps, not landed to consume new swift-log features. Command's own source doesn't reference any 1.14/1.15-only API, so walking swift-log back to 1.13.2 is a no-op for Command and lets the pipe-drainer fix reach tuist install immediately.

What changed

  • Package.swift: apple/swift-log back to .upToNextMajor(from: "1.13.2").
  • Package.resolved: pinned back to 1.13.2.

Follow-up (not in this PR)

  • Renovate rule to cap apple/swift-log below 1.14 so the same bump doesn't land again next week. Happy to file that as a separate PR once this is in.

Test plan

🤖 Generated with Claude Code

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant