Fix/dtc module picker scroll - #212
Merged
Merged
Conversation
The module ListView used WRAP_CONTENT, so with many modules it claimed its full height and pushed the Cancel/Select All/Confirm bar out of the dialog. Use 0 height + weight 1 so the list shrinks and scrolls instead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The weighted ListView alone still claimed the full dialog height with long module lists, hiding the button bar. Replace it with MaxHeightListView, capped at 40% of the screen height, and give it an always-visible custom scrollbar thumb so it's clear more modules sit below the fold. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Horizontal LinearLayouts baseline-align children by default, so a disabled Share button (different background padding) pushed Close out of line. Disable baseline alignment on both button rows. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.