Skip to content

fix: alias fastcgi-php8.4.conf to the PHP 8.5 snippet (tenant config compat) #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andypotanin merged 1 commit into from
Oct 21, 2026
Merged

fix: alias fastcgi-php8.4.conf to the PHP 8.5 snippet (tenant config compat) #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ RUN sed -i "s|\${PHP_VERSION}|${PHP_VERSION}|g" /etc/nginx/snippets/fastcgi-php"
sed -i "s|\${PHP_VERSION}|${PHP_VERSION}|g" /etc/nginx/sites-available/default && \
sed -i "s|\${USER}|${USER}|g; s|\${PHP_VERSION}|${PHP_VERSION}|g" /etc/php/"${PHP_VERSION}"/fpm/pool.d/www.conf && \
grep -q "^include=/etc/php/${PHP_VERSION}/fpm/pool.d/*.conf" /etc/php/"${PHP_VERSION}"/fpm/php-fpm.conf || \
echo "include=/etc/php/${PHP_VERSION}/fpm/pool.d/*.conf" >> /etc/php/"${PHP_VERSION}"/fpm/php-fpm.conf
echo "include=/etc/php/${PHP_VERSION}/fpm/pool.d/*.conf" >> /etc/php/"${PHP_VERSION}"/fpm/php-fpm.conf && \
ln -sf /etc/nginx/snippets/fastcgi-php"${PHP_VERSION}".conf /etc/nginx/snippets/fastcgi-php8.4.conf

@devin-ai-integration devin-ai-integration Bot Oct 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 PHP 8.4 image build fails

With PHP_VERSION=8.4 and an available package version, ln attempts to replace the snippet with a link to itself. It exits with an error, so the image build fails.

Suggested change
ln -sf /etc/nginx/snippets/fastcgi-php"${PHP_VERSION}".conf /etc/nginx/snippets/fastcgi-php8.4.conf
if [ "${PHP_VERSION}" != "8.4" ]; then ln -sf /etc/nginx/snippets/fastcgi-php"${PHP_VERSION}".conf /etc/nginx/snippets/fastcgi-php8.4.conf; fi

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


# Set PHP-FPM socket permissions in the configuration
RUN sed -i "s|^error_log =.*|error_log = /dev/stderr|" /etc/php/"${PHP_VERSION}"/fpm/php-fpm.conf && \
Expand Down
Loading