Repository navigation
web: keep the team avatar remove button in place when there's no avatar - #47
Merged
Merged
Conversation
The remove button used to be unmounted when no avatar was uploaded, so the footer row shifted between the two states. Now it always renders. When there's no avatar it is disabled, hidden with opacity 0 and marked aria-hidden, so it still takes up its space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The footer row on the Team Avatar card shifted between the "avatar uploaded" and "no avatar" states. This happened because the remove button was unmounted whenever there was no avatar.
opacity-0and markedaria-hidden, so it keeps its space and the layout no longer moves.