Repository navigation
web | docs: shrink grabbed cards and pick them up on a short hold - #49
Merged
Merged
Conversation
- With a mouse, a card is now picked up after being held still for 300ms, not only after it moves. Moving still picks it up right away, and moving during the hold doesn't cancel it. - The picked-up card in the drag overlay shrinks a little. When it is dropped, it grows back to full size as it lands, even if it lands where it started. dnd-kit's default drop animation skips that case. - dnd-kit now measures the overlay without its transform, so the shrink doesn't throw off where the card lands. - Pressing a card's menu button no longer starts a drag, because those menus open on press. - The docs now say that pressing and holding a card picks it up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you grab a project or service card to reorder it, the card now shrinks a little so it's clear it has been picked up. With a mouse, you can also pick a card up by holding it still for a moment. Before, it only picked up once it moved.
animate-card-grab).aria-haspopup="menu") no longer starts a drag, because those menus open on press. Without this, the new hold would pick the card up.Both the project cards and the service blocks use these changes through the shared helpers in
card-sorting.ts.