Repository navigation
web: fade card drag shadows and keep the drop outline until it lands - #50
Merged
Merged
Conversation
- The grabbed card's shadow now fades in when it's picked up and fades out during the drop animation. Before, it appeared and disappeared all at once. - The drop animation no longer runs dnd-kit's default side effects. Instead, it marks the source card with data-drag-source until the animation finishes, so the dashed outline stays in place until the card reaches it. - Grabbed cards now shrink to 96% instead of 97%. - Mouse drags now start after a 250ms hold instead of 300ms, the same as touch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polishes how cards look when you pick them up and drop them.
card-shadow-inkeyframe) and fades out during the drop animation. Before, it appeared and disappeared all at once. Cards mark the element that carries their shadow withdata-card-shadowso the overlay and the drop animation can find it.dropCardno longer calls dnd-kit's default dropsideEffects. Instead, it setsdata-drag-sourceon the source card until all drop animations finish, so the dashed outline stays in place until the card reaches it. This only replaces the drop animation's visual side effects, which dnd-kit lets you customize throughdropAnimation. Sorting, sensors and drop handling still work as dnd-kit intends.This affects service, service group and project cards.