refactor: migrate print_symbol to map-level raw: :content - #34
Merged
Merged
Conversation
lutaml-model deprecates attribute-level raw: true in favor of declaring rawness on the XML mapping (raw: :content), which is where it semantically belongs. Behavior verified unchanged: parsed print_symbol values and XML round-trip output are byte-identical for the full UCUM fixture (336 entities).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the three deprecated
attribute :print_symbol, :string, raw: truedeclarations inlib/unitsdb/ucum.rb(UcumBaseUnit,UcumPrefix,UcumUnit) to the mapping-level equivalent:lutaml-model deprecated attribute-level
raw: true; rawness is a property of how the XML element maps, not of the attribute type.raw: :contentpreserves the element's inner content verbatim — needed because UCUM essence<printSymbol>values can contain character entities and nested markup (e.g.°C) that must survive XML → model → XML round-trips losslessly.Verification
Behavior is unchanged, verified against the full UCUM fixture (336 entities):
print_symbolvalues: identical before/afterto_xmlround-trip output: byte-identical before/after