Repository navigation
[meta-version-updater] Version updates - #225
platformsh-devrel wants to merge 3 commits into
Conversation
|
📋 PR Summary This is an automated meta-version-updater PR that bumps runtime package versions in the image registry. The latest push changes two entries: the 26.8 image goes from 26.8.31.2 to 26.8.32.14 and the 1.27 image goes from 1.27.2-0psh1 to 1.27.3-0psh1. Both entries get matching updates to their normalized patch versions. Changes
|
There was a problem hiding this comment.
Warning
Changes suggested — 🟡 1 warning
🔍 Full review · 1 file reviewed
Verification
- Both ClickHouse package_version bumps (26.8.31.2, 26.3.56.2) keep
normalizedequal to the first three components ofrawand leavemajorMinorunchanged. - The edited registry.json still parses as valid JSON.
- The nodejs 24 status change is in the
upstreamblock only;upsun.statusstayssupported, as it does for the other upstream-deprecated entries such as nodejs 22.
The diff adds or changes no tests. I found no code in the repository that reads these fields (a grep for isEoas in Go/JS/TS/Python/PHP sources turned up nothing), so nothing automated checks that status and isEoas agree. I checked the JSON parses and looked for field mismatches with a one-off Python script.
Review details
- Commit: b4d1dab
- Model: claude-opus-5-5
Review 1 of 10 for this pull request · View the full run
| }, | ||
| "upstream": { | ||
| "status": "supported", | ||
| "status": "deprecated", |
There was a problem hiding this comment.
🟡 Warning — Docs and tooling that read isEoas will keep calling Node 24 actively supported after it was deprecated upstream.
This change moves nodejs 24 to upstream.status: "deprecated" but leaves isEoas: false in the same object, a few lines down. Its eoasFrom is 2026-10-20, which is today, so support has ended. Elsewhere in the registry, 14 deprecated entries pair the status with isEoas: true, including nodejs 22 just above. The new entry contradicts itself: a consumer that reads isEoas reports Node 24 as still supported, and one that reads status reports it as deprecated. The only other deprecated entries with isEoas: false are redis 8.0 and redis 7.2, and their inconsistency was already in the file before this PR.
There was a problem hiding this comment.
Note
Reviewed — No new issues found · 1 still open
🔁 Incremental · 1 file reviewed
Outstanding from earlier reviews:
- 🟡 #4320109209 —
resources/image/registry.json:6356: Docs and tooling that readisEoaswill keep calling Node 24 actively supported after it was deprecated upstream. — nodejs 24 upstream still reads status "deprecated" with isEoas false, even though eoasFrom is 2026-10-20 (today).
Verification
- The ClickHouse 26.3 bump changes
rawto 26.3.57.12 andnormalizedto 26.3.57; both still matchmajorMinor26.3. - The 1.26 package bump changes
rawto 1.26.10-0psh1 andnormalizedto 1.26.10; both stay consistent withmajorMinor1.26. - The merged registry.json still parses as valid JSON.
No test in this diff covers these changes. This pass only bumped two package_version entries in generated data, and I checked by hand that they agree with their majorMinor fields.
Review 2 of 10 for this pull request · View the full run
There was a problem hiding this comment.
Note
Reviewed — No new issues found · 1 still open
🔁 Incremental · 1 file reviewed
Outstanding from earlier reviews:
- 🟡 #4320109209 —
resources/image/registry.json:6356: Docs and tooling that readisEoaswill keep calling Node 24 actively supported after it was deprecated upstream. — nodejs 24 upstream still has status "deprecated" next to isEoas: false, even though eoasFrom is 2026-10-20 and that date has passed.
Verification
- The ClickHouse 26.8 bump keeps
raw26.8.32.14,normalized26.8.32 andmajorMinor26.8 consistent with each other. - The 1.27 bump keeps
raw1.27.3-0psh1 andnormalized1.27.3 consistent withmajorMinor1.27. - The merged registry.json still parses as valid JSON.
No tests cover this data-only registry update. I checked by hand that the changed version fields agree with each other and that the file still parses as JSON.
Review 3 of 10 for this pull request · View the full run
This PR is auto-generated by meta-version-updater.
Summary of updates
resources/image/registry.json