Repository navigation
fix(release): build binaries from the bumped version - #26
Merged
Merged
Conversation
Release binaries were compiled from the pushed commit, before sr bumped the version, so each release reported the previous version (and self-update kept re-downloading the same release). Add a prepare job that runs sr in prepare mode and uploads the bumped manifests; the build jobs apply them before compiling. Builds now only run when there is something to release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Release binaries are compiled from the pushed commit, before sr bumps the version in the release job, so every release reports the previous version. Observed: v0.15.2 binary reports 0.15.1; v0.15.1 reports 0.15.0.
Fix
Follows the plan → prepare → release shape documented in
urmzd/sr@v9(and used bysritself):preparejob runsurmzd/sr@v9withmode: prepareand uploads the bumpedCargo.toml/Cargo.lockfilescargo buildpreparereports a bump; the release job is unchangedVerified locally:
sr prepareon agentspec at58f4146bumped Cargo.toml, Cargo.lock and crate manifests to 0.15.2, exit 0.Test plan
ci → prepare → build → release)fix:commit cuts a patch release; confirm the published aarch64-apple-darwin binary reports the new tag