Repository navigation
Conversation
ubc 0.39 warns config.codelinks_removed_key for it, and False is its default in sphinx-codelinks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The 30 test specifications move from @rst blocks in the test sources to `// @need <GTest name>, <id>, test, [<tests>]` comments, read by a `tests` codelinks project like the implementation needs. Each component shows them in its Verification section with src-trace. Only a test-kit build compiles the test sources, so codelinks takes their #ifdef branches from that build's compile database and skips them in any other. spl-core's results converter finds the specifications in the clanguru listings, so their `results` links are gone until the next commit derives them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ective sphinx-test-reports 4 and ubc 0.39 both read the test-report directive, so spl-core writes it again (SPL_TEST_RESULTS_AS_NEEDS OFF) and both readers take its settings from the [test_reports] table. The extension registers the testfile, testsuite and testcase types and fields, so the hand-declared copies go, and so does conf.py's filter for `file`. A test specification's `results` link is derived in ubproject.toml (sphinx-needs 9): the test cases whose `case` is the specification's title. The vendored-config check compares only the link names, since the derive is this project's own. Needs spl-core with sphinx-needs >=9.2 and sphinx-test-reports >=4, and sphinx-codelinks 2.1, which this commit does not pin yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A join compares exactly, so a specification titled `Suite/Test.Case/*` lost the results the old converter matched by wildcard. Each specification now names the GTest cases it covers in a `test_cases` field, separated by `\,`, and the derived `results` link joins on it: TS_LC-003, TS_MCK-001, TS_FC-001 and TS_FC-100 link their 3, 7, 4 and 4 instances again. The field is a string because ubc drops a codelinks list field that is not a link type, and the join splits a string on commas, so the two instance names with a comma are renamed. Drop the field once ub-test-reports splits the GTest instance into case_parameter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test specifications move into the test sources as codelinks one-line comments, like the implementation needs. Test results come from sphinx-test-reports'
test-reportdirective again, which ubc 0.39 now reads as well.Draft: CI can't pass until the dependency stack below is pinned.
Changes, one commit each
get_rst. ubc 0.39 warns about the key, andFalseis already its default.@rst .. test::blocks to// @need <GTest name>, <id>, test, [<tests>]comments in a newtestscodelinks project.## Verificationviasrc-trace.#ifdefbranches using the test-kit build's compile database.test-reportdirective.SPL_TEST_RESULTS_AS_NEEDSis turned OFF, and a[test_reports]table is shared by both readers.resultsis now a sphinx-needs 9 derived link: each spec links to the test cases whosecasematches.Suite/Test.Case/*can't match its instances.test_cases, separated by\,.Need-level comparison with CI run 42134750198 (
d351c44, Disco and Spa test reports)resultslinks, including the parameterised ones (TS_LC-003: 3, TS_MCK-001: 7, TS_FC-001: 4, TS_FC-100: 4).docnameis now its component page.remote-url.is_importset to false.Verification (local, macOS)
test_ubproject_config.py: 29 passed.Open points before this can merge
sphinx-needs >=9.2,<10,sphinx-test-reports >=4,<5, and the extension loaded assphinx_test_reports(prototyped on branchfeat/sphinx-test-reports-4fromce62088, not pushed yet).sphinx-codelinks >=2.1,<3, then updatepoetry.lock. The AGENTS.md pin paragraph needs updating too.ubproject.toml. Because of that,errorsdiffers between the readers unnoticed: -1 in Sphinx, 0 in ubc.case_parameter, sotest_casescan be removed. The task has been handed to the rollout session.🤖 Generated with Claude Code