Skip to content

build(deps): enforce a 5-day release cooldown for uv and npm resolution - #1556

Merged
bearsyankees merged 1 commit into
mainfrom
chore/str-1607-release-cooldown
Oct 21, 2026
Merged

bearsyankees merged 1 commit into
mainfrom
chore/str-1607-release-cooldown

Conversation

@bearsyankees

Copy link
Copy Markdown
Collaborator

No description provided.

@bearsyankees
bearsyankees merged commit a3c3123 into main Oct 21, 2026
10 of 13 checks passed
@greptile-apps

greptile-apps Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The cooldown changes dependency selection across Python and viewer build workflows.

The PR appears safe to merge, with a non-blocking improvement to enforce the required npm version.

Findings

  1. P2 Older npm misses the cooldown ▶
Fix with agent prompt
### Issue 1
strix/interface/viewer/frontend/.npmrc:1-2
This setting requires npm >=11.10, but the frontend declares no minimum npm version, and CI selects only a Node version. If a contributor uses older npm, dependency updates can skip the intended five-day cooldown. Declare and enforce the minimum npm version so an unsupported client cannot silently bypass this setting.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Adds a five-day cooldown for dependency resolution.

  • Python and viewer dependency installs now wait five days for new releases.

Reviews (1) · Last reviewed commit: "build(deps): enforce a 5-day release coo..." · Reviewed by Greptile

Comment on lines +1 to +2
# Supply-chain cooldown: only install versions published at least 5 days ago (npm >= 11.10).
min-release-age=5

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Older npm misses the cooldown

This setting requires npm >=11.10, but the frontend declares no minimum npm version, and CI selects only a Node version. If a contributor uses older npm, dependency updates can skip the intended five-day cooldown. Declare and enforce the minimum npm version so an unsupported client cannot silently bypass this setting.

Prompt To Fix With AI
This is a comment left during a code review.
Path: strix/interface/viewer/frontend/.npmrc
Line: 1-2

Comment:
**Older npm misses the cooldown**

This setting requires npm >=11.10, but the frontend declares no minimum npm version, and CI selects only a Node version. If a contributor uses older npm, dependency updates can skip the intended five-day cooldown. Declare and enforce the minimum npm version so an unsupported client cannot silently bypass this setting.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant