Repository navigation
build(deps): enforce a 5-day release cooldown for uv and npm resolution - #1556
Merged
Merged
Conversation
Contributor
[Medium impact] The cooldown changes dependency selection across Python and viewer build workflows. The PR appears safe to merge, with a non-blocking improvement to enforce the required npm version. Findings
Fix with agent prompt### Issue 1
strix/interface/viewer/frontend/.npmrc:1-2
This setting requires npm >=11.10, but the frontend declares no minimum npm version, and CI selects only a Node version. If a contributor uses older npm, dependency updates can skip the intended five-day cooldown. Declare and enforce the minimum npm version so an unsupported client cannot silently bypass this setting.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryAdds a five-day cooldown for dependency resolution.
Reviews (1) · Last reviewed commit: "build(deps): enforce a 5-day release coo..." · Reviewed by Greptile |
Comment on lines
+1
to
+2
| # Supply-chain cooldown: only install versions published at least 5 days ago (npm >= 11.10). | ||
| min-release-age=5 |
Contributor
There was a problem hiding this comment.
This setting requires npm >=11.10, but the frontend declares no minimum npm version, and CI selects only a Node version. If a contributor uses older npm, dependency updates can skip the intended five-day cooldown. Declare and enforce the minimum npm version so an unsupported client cannot silently bypass this setting.
Prompt To Fix With AI
This is a comment left during a code review.
Path: strix/interface/viewer/frontend/.npmrc
Line: 1-2
Comment:
**Older npm misses the cooldown**
This setting requires npm >=11.10, but the frontend declares no minimum npm version, and CI selects only a Node version. If a contributor uses older npm, dependency updates can skip the intended five-day cooldown. Declare and enforce the minimum npm version so an unsupported client cannot silently bypass this setting.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.