Repository navigation
Conversation
ModelPollerService and the log-cleanup/model-poller processors import @nestjs/bullmq and bullmq, which are no longer dependencies since the Redis/PostgreSQL stack was dropped. Nothing imports them (JobsModule only provides LogCleanupService), but the webpack type-check covers all of src/, so `bun run build` (and the Dockerfile backend-builder stage) fails with TS2307.
redis-server is no longer installed in the image (the Redis/BullMQ stack was removed), but docker/services.d/redis/run is still copied into /etc/services.d, so s6 restarts it forever: "exec: redis-server: not found". The published wojooo/inker:0.6.0 image has no such service.
docloulou
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building the image from
maindoes not reproduce the publishedwojooo/inker:0.6.0:bun run build(Dockerfile stagebackend-builder) fails with 6× TS2307:Cannot find module '@nestjs/bullmq'/'bullmq'insrc/jobs/processors/{log-cleanup,model-poller}.processor.tsandsrc/jobs/services/model-poller.service.ts. These are leftovers from the Redis/BullMQ stack: the packages are gone frompackage.json, and nothing imports the files (JobsModuleonly providesLogCleanupService, which uses@nestjs/schedule). Nest's webpack type-checker checks everything undersrc/, so the dead files break the build.docker/services.d/redis/runis still copied to/etc/services.d, butredis-serveris no longer installed, so s6 loops forever onexec: redis-server: not found. The published 0.6.0 image only has thebackendandnginxservices. With this change, the/etc/cont-init.dand/etc/services.dcontents of a source build match it exactly (md5).After the change:
bun run buildcompiles successfully andbun testgives 432 pass / 0 fail. Spotted while building #34 from source.