Skip to content

fix: sanitize shell/subprocess call in repo-refresh.js (CWE-78) #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: sanitize shell/subprocess call in repo-refresh.js (CWE-78) #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/repo-refresh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,28 @@ function createRepoRefreshManager(opts = {}) {
}

// ── Fetch runner ─────────────────────────────────────────
// gitRoot must be an absolute, already-normalized path with no NUL bytes
// and no leading '-' (which git/execFile could otherwise mistake for an
// option). This is defense-in-depth on top of the known-gitRoots gate in
// repo-refresh-routes.js, in case this manager is ever wired to a less
// careful caller.
function isSafeGitRoot(p) {
return typeof p === 'string' && p.length > 0 && !p.includes('\0')
&& path.isAbsolute(p) && path.normalize(p) === p
&& !path.basename(p).startsWith('-');
}

function runFetch(gitRoot) {
return new Promise((resolve) => {
if (!isSafeGitRoot(gitRoot)) {
resolve(setState(gitRoot, {
status: 'error',
startedAt: null,
lastError: truncateErr('invalid gitRoot'),
lastErrorAt: Date.now(),
}));
return;
}
let timeoutFired = false;
let killTimer = null;
let timeoutTimer = null;
Expand Down