Repository navigation
mbp-1188: Enable consolidated Argo CD instances - #187
Merged
Merged
Conversation
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
Contributor
There was a problem hiding this comment.
Are these changes relevant to this PR?
Collaborator
Author
There was a problem hiding this comment.
yes, because when consolidating the instances, I encountered a race condition in the keycloak set up. This didn't happen when there were two instances, possibly due to a longer reconciliation interval for the resources, but after switching to a single instance, I found that the temporary secret we use was being deleted before the domain could be imported, which caused an error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable consolidated Argo CD via
global.singleArgoCD: trueinvalues-global.yaml, so pattern apps are managed from a single Argo CD instance.Update user docs (
README.md,docs/supply-chain.md,docs/oidc/entraid.md), Vault network policy overrides,gen-imageset-config.pycomments, and hub interop tests to use thevp-gitopsnamespace instead oflayered-zero-trust-hub.