Repository navigation
Implement variants and switch to vp-s4-storage - #26
Merged
Merged
Conversation
day0hero
commented
Sep 30, 2026
day0hero
commented
Contributor
- Patternizer upgrade to get ci hook updates.
- updating subscriptions,namespaces..etc
- variant implementation
- configure tempostack to use vp-s4-storage
- updated values-secret template
- Added tests/ci for testing
- Added test to lookup gateway for travel-control since it isn't a route. - Converted UI tests from typescript to python.
- added vp-s4-storage chart and needed to update the secrets template to account for new requirements
mhjacks
previously requested changes
Sep 30, 2026
mhjacks
left a comment
mhjacks
left a comment
Contributor
There was a problem hiding this comment.
I think we should exclude pycache (i.e. under tests/ci) via gitignore. The rest of the PR looks OK to me.
Contributor
|
LGTM now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.