Fix version_bumper.yaml not checking for empty appVersion - #129
Open
briiians wants to merge 2 commits into
Open
Conversation
Collaborator
|
Shouldn't |
Collaborator
|
I agree with @gquintard on this, hard fails are better than silently skipping. If it can't figure out the version, something is wrong in the script and should be fixed. |
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Collaborator
Author
|
Okay it hard fails now, let me know if you would prefer something else |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up in #122, where the chart version got bumped but appVersion ended up as an empty string.
The version_bumper workflow never checked whether LATEST_APP_VERSION actually came back non-empty from the docker run step. If that step fails for any reason, the empty string still gets treated as a "new" version since it doesn't match the current one, and a PR goes out with a blank appVersion.
This adds a check that skips the run instead of opening a bad PR when the version can't be determined.