Repository navigation
Build in cloud build: image toolchain, no lint in packaging, tool packages from source - #89
Merged
Merged
Conversation
apt has no python3.11 on focal or bullseye and its CMake is older than the 3.25 viam-cpp-sdk needs, while conancenter's prebuilt b2 requires glibc 2.32 against the 2.31 floor; the apt upgrade also rewrote the build image on every run. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The lint target installs clang-format-19 through apt, which no cloud build image carries, so the module build failed after compiling everything; formatting stays a separate target. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
conancenter ships those as binaries linked against a newer glibc than 2.31, and autom4te rejects the m4 that cannot run, which breaks the libcurl source build. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
Hey Ale Paredes (@ale7714) — CI is green and no reviewer is assigned yet. Could you request one when you have a chance? Auto-comment from overwatch. Will not re-nudge for 7 days. |
1 similar comment
Contributor
|
Hey Ale Paredes (@ale7714) — CI is green and no reviewer is assigned yet. Could you request one when you have a chance? Auto-comment from overwatch. Will not re-nudge for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud builds of this module fail on the glibc 2.31 images before, during and after the build.
bin/setup.shranapt upgradeon the image and installedpython3.11andcmakefrom apt: no focal or bullseye apt carries python3.11, and their CMake is older than the 3.25 viam-cpp-sdk needs. The script now installs only wget, uses the image's Python 3.11, and puts the pipcmakewheel in the venv next to conan.Packaging then ran
lintfirst, which tries to apt-install clang-format-19 and fails; formatting stays its own target.Three conan tool packages come prebuilt from conancenter against a newer glibc than 2.31 and are forced from source: b2 (boost), and m4 and pkgconf, which the libcurl autotools build needs and whose broken m4 made autom4te stop. Once viamrobotics/viam-cpp-sdk#715 publishes a glibc 2.31 b2 that flag is redundant; m4 and pkgconf stay.
Verified on the cloud build image: amd64 21462 and arm64 21463 pass.
🤖 Generated with Claude Code