Repository navigation
Conversation
Contributor
Author
|
Hi @prashant1221 , could you please review the PR? Thank you in advance for a short comment. Best wishes, Daniel |
dcasota
pushed a commit
to dcasota/photonos-scripts
that referenced
this pull request
Sep 11, 2026
`fix/cloud-init-generator-libexecdir` (dcasota/photon#32, vmware/photon#1676) is now part of the branch set both installer variants are built from, so every ISO the matrix builds carries cloud-init 26.2-3 rather than 26.2-2. Without it the generator resolves ds-identify under /usr/lib while the meson install puts it in /usr/libexec, exits 3, and every 26.2 guest reports "status: not started" where a 25.1.3 guest reports "done". Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dcasota
force-pushed
the
fix/cloud-init-generator-libexecdir
branch
from
September 17, 2026 06:02
38bc54e to
68f70a3
Compare
dcasota
added a commit
to dcasota/photonos-scripts
that referenced
this pull request
Sep 26, 2026
minimal Requires cloud-init, and make image does not rebuild an install-only dependency, so the older cloud-init 26.2-2 RPM kept being used and the branch's 26.2-3 (vmware/photon#1676) never reached the ISO. v5 adds cloud-init to the pre-build list next to the STIG set. Verified on a fresh kickstart install of linux-esx 7.3-rc4 (PVSCSI, vmxnet3): 0 journal lines for "missing module BTF", "Failed to find module" and "cloud-init-generator failed"; rdrand_rng loaded; cloud-init status done; system running. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
dcasota
force-pushed
the
fix/cloud-init-generator-libexecdir
branch
from
September 27, 2026 07:30
68f70a3 to
8d58023
Compare
dcasota
force-pushed
the
fix/cloud-init-generator-libexecdir
branch
from
October 9, 2026 07:24
8d58023 to
2f4e974
Compare
cloud-init 26.2 is built with meson, which installs its helper scripts
in libexecdir:
/usr/libexec/cloud-init/write-ssh-key-fingerprints
/usr/libexec/cloud-init/hook-hotplug
cloudinit/distros/photon.py does not override Distro.usr_lib_exec, which
defaults to /usr/lib in cloudinit/distros/__init__.py:132 (rhel.py:30
sets /usr/libexec). cc_keys_to_console.py:36 therefore looks for
write-ssh-key-fingerprints under /usr/lib/cloud-init and does not find
it, and Distro.get_clouddir() (distros/__init__.py:1406) resolves to the
same wrong directory.
Set usr_lib_exec to /usr/libexec in photon.py, as for the other RPM
distributions whose meson build installs helpers to libexecdir.
Only the mainline spec (subrelease 92 and later) is affected. SPECS/91
(25.1.3) and SPECS/90 (25.1.3) install the helpers under %{_libdir},
where the default resolves correctly.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dcasota
force-pushed
the
fix/cloud-init-generator-libexecdir
branch
from
October 22, 2026 18:23
2f4e974 to
c797b44
Compare
dcasota
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cloud-init 26.2 (
SPECS/cloud-init, subrelease 92 and later) is built with meson, which installs its helper scripts in libexecdir:cloudinit/distros/photon.pydoes not overrideDistro.usr_lib_exec, which defaults to/usr/libincloudinit/distros/__init__.py:132(rhel.py:30sets/usr/libexec). Two readers resolve to the wrong directory:cloudinit/config/cc_keys_to_console.py:36looks forwrite-ssh-key-fingerprintsunder/usr/lib/cloud-initand does not find itDistro.get_clouddir()(cloudinit/distros/__init__.py:1406) returns/usr/lib/cloud-init/clouddirSPECS/91/cloud-initandSPECS/90/cloud-init(25.1.3) install the helpers under%{_libdir}/cloud-init, where the default resolves correctly.Change
0012-photon-usr-lib-exec-is-libexecdir.patch:usr_lib_exec = "/usr/libexec"incloudinit/distros/photon.py, as for the other RPM distributions whose meson build installs helpers to libexecdir.SPECS/cloud-init/cloud-init.spec:Patch11, Release 26.2-4 -> 26.2-5, one%changelogentry.Testing
%prepapplies all patches of the spec to the checksum-verified 26.2 tarball at--fuzz=0; the preparedphoton.pysetsusr_lib_exec = "/usr/libexec".rpmspec -P(x86_64 and aarch64) andcheck_spec.py --mainline 93pass at subreleases 92 and 93.🤖 Generated with Claude Code