Repository navigation
Replace params.pp with module data in Hiera - #762
Merged
Merged
Conversation
kenyon
requested changes
Oct 25, 2026
theurw101
force-pushed
the
migrate-from-params-to-hiera
branch
from
October 26, 2026 19:39
8c9db67 to
de08427
Compare
Contributor
Author
|
@kenyon Thanks for the feedback. I have implemented the changes you requested. In |
kenyon
requested changes
Oct 26, 2026
kenyon
left a comment
kenyon
left a comment
Member
There was a problem hiding this comment.
Please add final newlines to those new YAML files, otherwise this looks good to me.
Update spec for params.pp to Hiera conversion Remove EL7, remove facts check, replace lookup with variable calls Add pre_condition to spec Add missing newlines
theurw101
force-pushed
the
migrate-from-params-to-hiera
branch
from
October 26, 2026 21:01
de08427 to
bba0433
Compare
kenyon
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR moves the OS-dependent defaults from
python::paramsinto data inmodules and removes the private
python::paramsclass and the obsoleteparams.pp(see #712 )This Pull Request (PR) fixes the following issues
Fixes #712