Skip to content

fix: keep the landing page version current and credit the author - #232

Merged
voyvodka merged 2 commits into
mainfrom
fix/landing-version-author
Oct 14, 2026
Merged

voyvodka merged 2 commits into
mainfrom
fix/landing-version-author

Conversation

@voyvodka

@voyvodka voyvodka commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • The landing page (index.html, served at webhook.sametozkan.com.tr) showed v0.1.6 in the header badge and footer and 0.1.3 in its structured data; the latest release is v0.4.1.
  • The version is no longer hand-written. index.html carries a {{version}} placeholder in those three places, and the Pages workflow fills it from the newest v<major>.<minor>.<patch> git tag at deploy time. The deploy fails if no such tag exists or a placeholder is left in the page.
  • The Pages workflow also runs after every successful Release run (workflow_run), so a new tag updates the page without touching index.html. A tag-triggered run would execute on refs/tags/*, which the github-pages environment refuses (its branch policy allows only main); workflow_run executes on the default branch. Checkout pins the default branch so a release never deploys an older index.html.
  • Footer credits the author: MIT License · v0.4.1 · by Samet Özkan, linking to https://www.sametozkan.com.tr/ (rel="author"); the structured-data author gains the @id that site uses for its Person.
  • CHANGELOG entry under [Unreleased] → Fixed.

The GitHub Release object is created by hand after the tag, so the tag (which also drives Docker and NuGet publishing) is the version source, not the Releases API.

Test plan

  • Staging step simulated locally: resolves v0.4.1, all three placeholders replaced, JSON-LD parses with softwareVersion: "0.4.1"
  • Footer rendering checked in a browser
  • CI green
  • After merge: the push-triggered Pages run deploys and the live page shows v0.4.1

The landing page header badge and footer still said v0.1.6 and its structured data said 0.1.3, long after v0.4.1 shipped; all three now say v0.4.1. The footer credits the author with a link to their site, and the structured-data author gains the @id that site uses for its Person so both describe one person.
@voyvodka voyvodka added the bug Something is not working label Oct 14, 2026
@voyvodka
voyvodka enabled auto-merge (squash) October 14, 2026 11:53
@voyvodka
voyvodka disabled auto-merge October 14, 2026 11:53
The landing page version was typed by hand and had fallen three minor releases behind. index.html now carries a {{version}} placeholder that the Pages workflow replaces with the newest v<major>.<minor>.<patch> tag, failing the deploy if no tag is found or a placeholder survives. The workflow also runs after every successful Release run, through workflow_run because the github-pages environment only deploys from main and a tag-triggered run would be refused.
@voyvodka voyvodka changed the title fix: show the current release on the landing page and credit the author fix: keep the landing page version current and credit the author Oct 14, 2026
@voyvodka voyvodka added the ci CI / GitHub Actions workflows label Oct 14, 2026
@voyvodka
voyvodka enabled auto-merge (squash) October 14, 2026 11:54
@voyvodka
voyvodka merged commit 01758d5 into main Oct 14, 2026
7 checks passed
@voyvodka
voyvodka deleted the fix/landing-version-author branch October 14, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is not working ci CI / GitHub Actions workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant