Repository navigation
Fix UnboundLocalError in SCIM User error handling - #667
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
The response hook raises HTTPError inside the requests call, so the local response variable is never assigned and every except branch in users.py failed with UnboundLocalError. Read the response from the exception instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wandb-scim/users.pyinstalls a response hook that callsraise_for_status(). The hook raisesHTTPErrorinside therequestscall, soresponseis never assigned. Eachexcept requests.HTTPErrorbranch then readsresponse.status_codeand fails withUnboundLocalErrorinstead of returning the documented error value.This change reads the response from the exception (
e.response) in all 10 handlers. Successful requests are unchanged.Fixes #666
Testing
A local HTTP server returns 404 (and 409 for
POST) for every request, and the test calls eachUsermethod against it:UnboundLocalError).requests==2.34.2(the version pinned inwandb-scim/examples/requirements.txt) and 2.31.0.