Skip to content

fix for macos - #112

Merged
wavefunction91 merged 1 commit into
wavefunction91:masterfrom
ryanmrichard:fix/assoc_legendre_libcxx
Oct 12, 2026
Merged

wavefunction91 merged 1 commit into
wavefunction91:masterfrom
ryanmrichard:fix/assoc_legendre_libcxx

Conversation

@ryanmrichard

Copy link
Copy Markdown
Contributor

Title. IntegratorXX doesn't compile with Apple Clang because it doesn't ship with the (optional) special functions.

@wavefunction91

Copy link
Copy Markdown
Owner

Thanks for this. CI never ran here: the workflow run needed approval as a first-time-contributor run, and it expired before anyone approved it, and GitHub won't re-run runs older than a month. Could you rebase onto master (or push any new commit)? I'll approve the run as soon as it appears.

I checked the change in the meantime. With clang 18 + libc++, master fails on std::assoc_legendre and this branch builds and passes, with the fallback compiled in; with GCC 13 the parity test against std::assoc_legendre is active and passes too.

@ryanmrichard
ryanmrichard force-pushed the fix/assoc_legendre_libcxx branch from 6f3f92a to f52dfab Compare October 9, 2026 13:40
@ryanmrichard

Copy link
Copy Markdown
Contributor Author

@wavefunction91 it's rebased and should be r2g.

@wavefunction91
wavefunction91 merged commit e56a92c into wavefunction91:master Oct 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants