Skip to content

Draft: switch AWS deployment from Serverless to CDK - #121

Open
colorchestra wants to merge 36 commits into
developfrom
deploy-2026
Open

colorchestra wants to merge 36 commits into
developfrom
deploy-2026

Conversation

@colorchestra

Copy link
Copy Markdown
Collaborator

No description provided.

@netlify

netlify Bot commented May 5, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for serene-narwhal-9b7b1c ready!

Name Link
🔨 Latest commit 479d725
🔍 Latest deploy log https://app.netlify.com/projects/serene-narwhal-9b7b1c/deploys/6a1c5c19c7e3970008456b39
😎 Deploy Preview https://deploy-preview-121--serene-narwhal-9b7b1c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 5, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for peaceful-raindrop-cb2462 ready!

Name Link
🔨 Latest commit 479d725
🔍 Latest deploy log https://app.netlify.com/projects/peaceful-raindrop-cb2462/deploys/6a1c5c19512fed00080fbb28
😎 Deploy Preview https://deploy-preview-121--peaceful-raindrop-cb2462.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for serene-narwhal-9b7b1c ready!

Name Link
🔨 Latest commit 2234b38
🔍 Latest deploy log https://app.netlify.com/projects/serene-narwhal-9b7b1c/deploys/6ab505efaede3c000770626f
😎 Deploy Preview https://deploy-preview-121--serene-narwhal-9b7b1c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for peaceful-raindrop-cb2462 ready!

Name Link
🔨 Latest commit 2234b38
🔍 Latest deploy log https://app.netlify.com/projects/peaceful-raindrop-cb2462/deploys/6ab505efee39fc000752a3e2
😎 Deploy Preview https://deploy-preview-121--peaceful-raindrop-cb2462.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jh0ker jh0ker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claudia und ich haben uns das mal vorgenommen. Alles in allem glaube ich gut. Kannst ja mal über meine Kommentare schauen und überlegen, was davon du dir noch vornehmen möchtest und was wir aufschieben.

Comment thread cdk/lib/cdk-stack.ts Outdated
Comment on lines +193 to +194
// 403 und 404 auf 200 und "Upps!"-Seite umbiegen; Originalverhalten
// langfristig vllt. so ändern, dass das nur App-Pfade betrifft und nicht z.B. API-Pfade

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja ich glaub das könnte tatsächlich ein Problem sein. Wir haben einen Service Worker der die Assets cached, wenn wir da einmal ein Asset laden was fehlt, wird er denke ich die "Upps!"-Seite als Response cachen. Das ist dann schwierig, wieder loszuwerden. Ist erstmal kein großes Problem, weil der Offline-Modus hinter einem Feature Flag sitzt, und nur dann auch der Service Worker anspringen sollte.

Aber trotzdem fragwürdig, ob das sinnvoll ist, das jetzt 1:1 zu übernehmen. Wir haben ja jetzt auch z. B. die OAC neu hinzugefügt, also ein 100% "sauberes" Refactoring, wo wir die alten Bugs mitschleppen, ist ja nicht zwingend unser Ziel oder?

Comment thread cdk/lib/cdk-stack.ts
Comment thread .github/workflows/_deploy.yml
Comment thread .github/workflows/_deploy-gated.yml
Comment thread cdk/lib/cdk-stack.ts Outdated
Comment thread cdk/README.md
Comment thread cdk/lib/cdk-stack.ts Outdated
Comment thread cdk/lib/cdk-stack.ts Outdated
Comment thread cdk/lib/config.ts Outdated
Comment thread cdk/test/cdk.test.ts

@jh0ker jh0ker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht gut aus 👍

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants