Skip to content

fix(hud): keep pointer interaction when recording starts #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lincoo2019 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix(hud): keep pointer interaction when recording starts #1162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions electron/windows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,10 +745,10 @@ export function setHudOverlayRecordingActive(recording: boolean): void {
hudOverlayFallbackExpanded = false;
applyHudOverlayBounds();
reassertHudOverlayCaptureProtection();
// Start in passthrough mode. Forwarded pointer movement lets the renderer
// make the visible HUD controls interactive when the pointer reaches them,
// while transparent parts never block the recorded application.
setHudOverlayMousePassthrough(true);
// Keep whatever hover state the renderer last reported. Forcing passthrough
// here made the HUD click-through right after the user pressed record, so the
// stop button swallowed clicks until the pointer moved again.
setHudOverlayMousePassthrough(hudOverlayIgnoringMouse);
}

export function createUpdateToastWindow(): BrowserWindow {
Expand Down