Repository navigation
fix: map driver name arrays in processKiller and increase port 9515 timeout - #950
Open
hoanle0126 wants to merge 1 commit into
Open
hoanle0126 wants to merge 1 commit into
hoanle0126 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
In
lib/start.jsandtest/only-driver-tests.js,processKiller(ports, processesName)is called with an array of driver names (Object.keys(opts.drivers), e.g.['chrome']). However,getConfigProcessesNameinlib/processKiller.jsranObject.keys(drivers)on that array, returning array indices (['0']) instead of mapping'chrome'to'chromedriver'('firefox'to'geckodriver','chromiumedge'to'msedgedriver', etc.). Whenstartwas invoked a second time withonlyDriver: 'chrome',processKillerfailed to terminate the existingchromedriverprocess by name and used a 100ms reachability check on port9515, causingcheck staring twice chromedriverto fail intermittently.This updates
getConfigProcessesNameto accept both driver name arrays and driver config objects, and increases the port9515isPortReachabletimeout inlib/start.jsfrom100to1000(matching the existing1000timeout used forfirefox).Fixes #901
Types of changes
Checklist