Skip to content

Auth: Fixed remember-device label wrapping - #179

Merged
whereareiam merged 2 commits into
whereareiam:devfrom
scar-day:fix/signin-remember-label-width
Nov 1, 2026
Merged

whereareiam merged 2 commits into
whereareiam:devfrom
scar-day:fix/signin-remember-label-width

Conversation

@scar-day

@scar-day scar-day commented Nov 1, 2026 •

Copy link
Copy Markdown

Summary

Allow the sign-in remember-device label to use the available field width instead of inheriting Forgejo’s 200 px desktop label width. This prevents premature wrapping for wider translations while retaining natural wrapping for longer text and narrow screens. The change is scoped to the remember-device row.

Closes #178. Scope discussion with maintainers is pending.

Before and after

Russian locale, 1440 × 900 viewport, DejaVu Sans. These captures use the live sign-in page with the label width toggled between the 200 px baseline and the proposed fix; they are not from the project’s dev preview.

Before After
Remember-device label wrapping Remember-device label on one line

Verification

  • bun run commit: formatting, build, type check and Vitest passed (581 tests).
  • A local browser regression against Forgejo 17.0.1 base CSS and the built theme covered Russian and longer labels, desktop and phone widths, clicking the label, and an unrelated inline label. The temporary test files are not part of this PR.
  • Checked the real sign-in page with the candidate theme CSS in dark and light modes at 320, 390, 768 and 1440 px; label click and keyboard activation worked. This used the live page with intercepted CSS, not the project’s dev preview.
  • bun run lint fails on both the unchanged base and this branch because the installed typescript-eslint does not yet support TypeScript 7; the existing CI workflow also skips ESLint for that reason.

Release notes

  • Title follows the Area: Description format and describes the user-visible fix.
  • Maintainer to apply the bug label.
  • No Forgejo upgrade steps are introduced.

@whereareiam whereareiam added the bug Fixes a bug that shipped in a release label Nov 1, 2026
@whereareiam
whereareiam merged commit 6d14d88 into whereareiam:dev Nov 1, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes a bug that shipped in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auth: Remember-device label wraps prematurely on the sign-in page

2 participants