Skip to content

fix(dbapi): fail pending queries on SQL connection loss #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rbavery wants to merge 7 commits into
base: main
Choose a base branch
from
+1,003 −38
Open

fix(dbapi): fail pending queries on SQL connection loss #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a2d27a8
fix(dbapi): fail pending queries on SQL connection loss
rbavery Sep 5, 2026
48999f3
fix(dbapi): synchronize query send with shutdown
rbavery Sep 21, 2026
bf9b1e0
fix(dbapi): make shutdown independent of stalled sends
rbavery Sep 21, 2026
d9b1b60
test(dbapi): cover TLS shutdown and rejected cursor reuse
rbavery Sep 21, 2026
e211002
fix: complete query-local result failures without closing connection
rbavery Sep 21, 2026
3365706
fix(dbapi): always deliver pending failures when transport teardown f…
sfishel18 Sep 22, 2026
66d0daa
fix(dbapi): close the WebSocket cleanly when no send is in flight
sfishel18 Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tests/test_connection_query_tracking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

import json
import queue
from unittest.mock import MagicMock
from unittest.mock import MagicMock, patch

import cbor2
import pyarrow
Expand All @@ -22,9 +22,8 @@
def _make_connection():
"""Create a Connection with a mocked WebSocket."""
mock_ws = MagicMock()
# Prevent the background thread from running the main loop
mock_ws.protocol.state = 4 # CLOSED state, so __main_loop exits immediately
return Connection(mock_ws)
with patch("wherobots.db.connection.threading.Thread.start"):
return Connection(mock_ws)


def _track_query(conn, execution_id="exec-1", state=ExecutionState.RUNNING, store=None):
Expand Down
Loading
Loading