Repository navigation
Fix Rubocop Style/DirectiveScope offenses - #579
Merged
Merged
Conversation
A newly released Rubocop version added Style/DirectiveScope, which flags disable/enable comment pairs wrapping a single statement in favor of a single disable-next directive. This was breaking CI on main since Gemfile.lock isn't checked in, so bundle install picks up the latest Rubocop satisfying the gemspec's '>= 1.72.0, < 2.0' range. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI on
mainstarted failing the Rubocop job (https://github.com/whitesmith/rubycritic/actions/runs/36947244586/job/110652082252). No code changed — a new Rubocop release added theStyle/DirectiveScopecop, which flags# rubocop:disable X/# rubocop:enable Xpairs that wrap exactly one statement, in favor of a single# rubocop:disable-next Xdirective. SinceGemfile.lockisn't checked in,bundle installresolves the newest Rubocop satisfying the gemspec's'>= 1.72.0', '< 2.0'constraint, and that newest release introduced the cop.What changed
Applied
rubocop -A --only Style/DirectiveScopeacross the 7 flagged offenses (comment-only changes, no logic touched):lib/rubycritic/cli/options/argv.rblib/rubycritic/cli/options/file.rblib/rubycritic/source_control_systems/git/churn.rb(2 offenses)lib/rubycritic/source_control_systems/perforce.rbtest/fakefs_helper.rbtest/integration/integration_test_helper.rbVerification
rubocop(latest, 1.91.0) reports 0 offenses across all 119 files afterward.🤖 Generated with Claude Code