Repository navigation
Add Simplified Chinese (zh-Hans) - #571
Merged
Merged
Conversation
Resources: - Localizable.xcstrings: zh-Hans for all 848 strings, and zh-Hans in project.pbxproj's knownRegions. Other languages are untouched. Two gaps found while doing it, both of which left English on screen in every language: - The catalog had drifted from the source: 92 strings that reach the UI (EA/Epic/GOG/itch.io sign-in pages, achievements, touch-control settings, the FPS graph, external drives) had never been extracted. They are added with a zh-Hans value only. - "All" and "Other" are looked up at runtime through L(), so extraction never saw them either; added as manual entries. - Two call sites built a String ternary, which Text(String) renders verbatim, so the empty-library note stayed English; they now go through L() like the rest of the library. Checked with xcstringstool compile (no warnings) and on an iPhone running iOS 27.2: library, filter chips and the empty-library note render in Chinese, and the built bundle carries 848 zh-Hans entries. Signed-off-by: symi-daguo <symi-daguo@gmail.com>
125hz
pushed a commit
that referenced
this pull request
Nov 5, 2026
Adds Simplified Chinese to the String Catalog. Nothing else changes for the five languages that are already there.
125hz
added a commit
that referenced
this pull request
Nov 5, 2026
…he translations check knows the sixth language (#571 follow-up) The 94 keys that existed only with a Chinese value are dropped (they were never looked up: the texts reach the screen through plain String parameters, and check-translations requires every key in every language); 31 Chinese values get positional placeholders (%1$@, %1$lld / %2$lld) matching the English; two trailing spaces are restored. tests/host/check-translations.py lists zh-Hans with the other five languages and checks it in knownRegions. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
icey9527
added a commit
to icey9527/Madeira-15.6
that referenced
this pull request
Nov 6, 2026
Upstream wave 7: Simplified Chinese for every catalog key (willfaust#571), a Japanese locale per game (willfaust#567), thread-context and JIT-pool fixes (willfaust#556), Steam depot overlap scoped per install folder (willfaust#576), achievements, DXT9 luminance render targets, and the index-range DXMT patch that now compiles against a newer dxmt. Kept the fork: the Chinese locale work now sits on upstream's full translation, the Japanese prefix and our GBK path both run, both font folders ship, and the vendored dxmt gained the two device methods the re-enabled patch needs. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Simplified Chinese to the String Catalog. Nothing else changes for the five languages that are already there.
What it does
Localizable.xcstrings:zh-Hansfor all 848 keys.project.pbxproj:zh-HansinknownRegions.Two gaps I hit while translating (both leave English on screen in every language, not just Chinese):
zh-Hansvalue only; other languages fall back to English exactly as they do today.AllandOtherare looked up at runtime throughL(), so extraction never saw them either. Added as manual entries.I also changed two call sites that built a
Stringternary (Text(search.isEmpty ? "..." : L("..."))), whichText(String)renders verbatim, so the empty-library note stayed English. They now go throughL()like the rest of the library. That is the only Swift change (2 lines).Checked
xcstringstool compilepasses with no warnings, positional specifiers (%@,%lld) preserved in every translation.v0.2.0, installed on an iPhone (iOS 27.2): library, filter chips and the empty-library note render in Chinese; the built bundle carries 848zh-Hansentries.de,es,ko,pt-BR,ru.Brand names (Steam, GOG, itch.io, Epic, EA, Wine, DXMT, Visual C++, …) and paths (
C:\…) are left as-is, and quotes around UI labels follow Chinese typography (「」).Happy to split the two catalog-gap items into their own PR, or to drop the Swift change, if you would rather review them separately.