refactor(agent): expose trait behaviors and retire the compact lifecycle - #129
Merged
Merged
Conversation
Checkpoint behaviors declared on a trait's registry data reach the compiler through TraitSpec.behaviors. The compacted tool outcome is removed from the caller states and the outcome schema: checkpointing replaced compaction and nothing produces or consumes that state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
traits.get_by_id,get_by_nameandget_allcarrybehaviorsfrom the trait's registry data intoTraitSpec, so checkpoint behaviors declared on traits reach the compiler.compactedtool outcome state is removed fromtool_caller.OUTCOME_STATEand the outcome schema enum. Checkpointing replaced compaction; nothing in the framework or dataflow produces or consumes that state.agent_options.checkpointinstead of the retiredcompactoption.Tests
"preserves checkpoint behaviors from registry data" fails on master (behaviors dropped) and passes here.
make run-tests,make run-lint,make check-manifestspass.