Repository navigation
Review the live head when a persona review request trails a push - #51
Merged
Merged
Conversation
On withastro/astro#18176 the author persona pushed a commit and requested a review 3 seconds later. GitHub's review_requested payload still named the previous head, so loadReviewSetup saw the live head differ and returned stale. The reviewer never ran, and the request stayed pending with nothing to retry it. - Persona-triggered reviews (review request or assignment) review the live head instead of rejecting a mismatch. Label-triggered reviews keep the stale check, since a label applies to a specific commit. - The author workflow waits (up to ~10s) for GitHub to report the pushed commit as the PR head before requesting reviews again. - The review workflow logs a warning when a review doesn't start, and an info line when it uses a head newer than the trigger's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
astro-reviewer3 seconds later; GitHub'sreview_requestedpayload still named the previous head, so review setup saw a different live head, returnedstale, and exited. The reviewer never ran and the request stayed pending with nothing to retry it.ignored/stalewith the reason), and an info line when it reviews a head newer than the trigger's.Testing
tests/review-persona.test.ts: a persona review whose trigger names an older head isreadyand reviews the live head (base SHA unchanged).tests/persona-handoff.test.ts:waitForPullHeadreturns once the head matches (case-insensitive) and gives up without throwing after its attempt budget.stale.Docs