Skip to content

Add fireworks palette - #5910

Open
DedeHai wants to merge 1 commit into
wled:mainfrom
DedeHai:fireworks_palette
Open

DedeHai wants to merge 1 commit into
wled:mainfrom
DedeHai:fireworks_palette

Conversation

@DedeHai

@DedeHai DedeHai commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Based on the idea by @RussStringham (see PR #5492)

What I changed:

  • sorted the colors in a rainbow order
  • added slight gradients to each color for some variation

Looks like this:
image

Summary by CodeRabbit

  • New Features
    • Added a Fireworks color palette featuring red, orange, yellow, green, blue, purple, and white gradients.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Repository UI (inherited), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ce39f468-5c98-4e9b-98dd-e347edf388be
📥 Commits

Reviewing files that changed from the base of the PR and between e22d1ff and ff62d56.

📒 Files selected for processing: 3
  • wled00/FX_fcn.cpp
  • wled00/const.h
  • wled00/palettes.cpp

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout: 30
  • GitHub Check: wled_build / Build Environments (esp32dev_hub75_forum_pinout)
  • GitHub Check: wled_build / Build Environments (esp32S3_wroom2)
  • GitHub Check: wled_build / Build Environments (esp32c5dev_8MB_qspi)
  • GitHub Check: wled_build / Build Environments (esp32c3dev_qio)
  • GitHub Check: wled_build / Build Environments (usermods)
  • GitHub Check: wled_build / Build Environments (esp8266_2m)
  • GitHub Check: wled_build / Build Environments (esp32dev_V4)
  • GitHub Check: wled_build / Build Environments (esp32s3dev_8MB_qspi)
  • GitHub Check: wled_build / Build Environments (esp32_eth_V4)
  • GitHub Check: wled_build / Build Environments (esp32c6dev_4MB)
  • GitHub Check: wled_build / Build Environments (esp32c3dev)
  • GitHub Check: wled_build / Build Environments (esp32s3dev_16MB_opi)
  • GitHub Check: wled_build / Build Environments (esp32s3_4M_qspi)
  • GitHub Check: wled_build / Build Environments (esp32_eth)
  • GitHub Check: wled_build / Build Environments (esp32s3_4M_qspi)
  • GitHub Check: wled_build / Build Environments (esp32s3dev_8MB_opi)
  • GitHub Check: wled_build / Build Environments (esp32dev)
  • GitHub Check: wled_build / Build Environments (esp32s3dev_16MB_opi_hub75)
  • GitHub Check: wled_build / Build Environments (esp32s3dev_4MB_qspi_hub75)
  • GitHub Check: wled_build / Build Environments (esp32dev_debug)
  • GitHub Check: wled_build / Build Environments (esp32c5dev)
  • GitHub Check: wled_build / Build Environments (nodemcuv2_compat)
  • GitHub Check: wled_build / Build Environments (esp32p4_16MB)
  • GitHub Check: wled_build / Build Environments (nodemcuv2)
  • GitHub Check: wled_build / Build Environments (lolin_s2_mini)
  • GitHub Check: wled_build / Build Environments (esp01_1m_full_compat)
  • GitHub Check: wled_build / Build Environments (esp32s3dev_8MB_none)
  • GitHub Check: wled_build / Build Environments (esp32_wrover)
  • GitHub Check: wled_build / Build Environments (esp8266_2m_compat)
  • GitHub Check: wled_build / Build Environments (esp01_1m_full)
🧰 Additional context used
📚 Code guidelines: 3
docs/hardening.instructions.md — configured
.github/agent-build.instructions.md — auto-discovered
AGENTS.md — configured
📓 Path-based instructions: 4
Apply the WLED security hardening rules from docs/hardening.instructions.md, and consult docs/securecode.instructions.md when more details are needed for actionable recommendations.

⚙️ CodeRabbit configuration file

Files:

  • wled00/const.h
  • wled00/FX_fcn.cpp
  • wled00/palettes.cpp
Follow the C++ coding conventions documented in docs/cpp.instructions.md and the general project guidelines in AGENTS.md and .github/copilot-instructions.md.

⚙️ CodeRabbit configuration file

Files:

  • wled00/const.h
  • wled00/FX_fcn.cpp
  • wled00/palettes.cpp
Applicability reference: AGENTS.md: # AGENTS.md — WLED AI Coding Agent & AI Code Review Reference See also: `.github/copilot-instructions.md`, `.github/agent-build.instructions.md`, `docs/cpp.instructions.md`, `docs/web.instructions.md`, `d...

📄 CodeRabbit inference engine (docs/hardening.instructions.md)

Files:

  • wled00/const.h
  • wled00/FX_fcn.cpp
  • wled00/palettes.cpp
Source excerpt: Avoid unexplained "magic numbers".

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • wled00/const.h
  • wled00/FX_fcn.cpp
  • wled00/palettes.cpp
🪛 Clang (14.0.6)
wled00/const.h

[error] 10-10: unknown type name 'constexpr'

(clang-diagnostic-error)

[error] 10-10: expected ';' after top level declarator

(clang-diagnostic-error)

🔇 Additional comments: 3
wled00/const.h: 1

10-10: LGTM!

wled00/palettes.cpp: 1

769-784: LGTM!

Also applies to: 883-884

wled00/FX_fcn.cpp: 1

228-228: LGTM!

Also applies to: 2414-2414

Walkthrough

The gradient palette count increases from 59 to 60. A Fireworks gradient palette is defined and registered after Traffic Light, and its name is added to the palette list.

Changes

Fireworks Palette

Layer / File(s) Summary
Add and register Fireworks palette
wled00/const.h, wled00/palettes.cpp, wled00/FX_fcn.cpp
The gradient palette count increases to 60. The new Fireworks palette defines color stops across red, orange, yellow, green, blue, purple, and white. It is registered after Traffic Light and added to the palette-name list. The palette-range comment now uses GRADIENT_PALETTE_COUNT.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Suggested reviewers: softhack007

Merge Risk: ⚪ Minimal · up to ff62d

Users can select the new Fireworks gradient palette, and the supplied changes align its registration, displayed name, and palette count. No concrete merge-blocking risk remains.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title, "Add fireworks palette," clearly and concisely describes the main change: adding the Fireworks color palette.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@softhack007

Copy link
Copy Markdown
Member

@DedeHai nice 😃 should we set this palette as the default in "fireworks" and "starburst" style effects?

@DedeHai

DedeHai commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator Author

@DedeHai nice 😃 should we set this palette as the default in "fireworks" and "starburst" style effects?

I thought about it but users may be used to how the FX look by default, many do not use presets and that would change the default looks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants