Guard fwTPM public name computation on buffer allocation success - #605
Merged
dgarske merged 1 commit intoSep 11, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is fully reviewed with no unresolved blocking issues.
Pull request overview
Guards fwTPM public-name computation against temporary-buffer allocation failure.
Changes:
- Gates marshaling and hashing on successful allocation.
- Preserves cleanup and propagates the allocation error.
File summaries
| File | Summary |
|---|---|
src/fwtpm/fwtpm_crypto.c |
Adds allocation-success guarding around public-name computation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dgarske
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CID 913526