Fix --enable-pqc build with --disable-wolfcrypt - #606
Merged
Merged
Conversation
aidangarske
approved these changes
Sep 11, 2026
Contributor
|
Nice quick fix. |
There was a problem hiding this comment.
🟡 Changes recommended
The fallback may fail to compile because size_t is not guaranteed to be defined.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Fixes standalone PQC builds when wolfCrypt is disabled and adds CI coverage.
Changes:
- Adds a no-wolfCrypt
wc_ForceZerofallback. - Guards wolfSSL-specific includes and configure probes.
- Adds standalone PQC build jobs.
File summaries
| File | Summary |
|---|---|
wolftpm/tpm2_types.h |
Adds the fallback; currently lacks a guaranteed size_t definition. |
tests/unit_tests.c |
Guards the wolfSSL ML-DSA include. |
configure.ac |
Skips unnecessary wolfSSL probes. |
.github/workflows/pqc-build-matrix.yml |
Adds standalone PQC CI coverage. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./configure --enable-pqc --enable-spi --disable-wolfcrypt && makefailed to build:wc_ForceZerowas declared only inside the wolfCrypt branch oftpm2_types.h, andtests/unit_tests.cincludedwc_mldsa.hgated only onWOLFTPM_MLDSA_SIGN, so wolfCrypt'sBAD_MUTEX_Eenumerator collided with wolfTPM's macro of the same name. Adds awc_ForceZerofallback for the no-wolfCrypt branch, guards the include, stops configure from probing a wolfSSL this mode never links, and adds astandalone-pqcCI job that builds the examples and unit tests (every existing PQC row uses--disable-examples, which is why this escaped).Fixes: