Repository navigation
Conversation
Throwaway validation for #26261: PR CI skips the localization job for `.xcstrings`-only changes, so neither plural lane runs against the changed catalog. --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The fold reports rejected translations on stderr, so the count read 0 even though 48 were rejected. --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation only — do not merge. Stacked on #26261; close once it has answered.
PR CI never runs the plural lanes for #26261: the localization job only triggers on
*.strings/*.stringsdictchanges, so an.xcstrings-only PR skips it, anddownload_localized_pluralsonly runs at betas.Read the ":warning: [DO NOT MERGE] Validate plural lanes for #26261" job. Every step is expected to pass:
generate_strings_file_for_glotpress skip_commit:true, as at code freeze, emits all sixeditor.textCounter.wordCount|==|plural.*originals with%1$dand none with%1$ld.download_localized_pluralswithoutANTHROPIC_API_KEYcompletes, keeps English%1$d, and the folded catalog compiles withxcstringstool.%1$ldones (expected until GlotPress re-translates the new original).Artifacts: the generated
enLocalizable.strings, the folded catalog and the fold log.CI can't answer how GlotPress itself highlights
%1$d; that shows once the new original is uploaded at the next code freeze.