Skip to content

[DO NOT MERGE] Validate plural fold for #26263 - #26342

Closed
mokagio wants to merge 1 commit into
mokagio/plural-fold-revalidate-kept-cellsfrom
mokagio/plural-fold-revalidate-validation
Closed

mokagio wants to merge 1 commit into
mokagio/plural-fold-revalidate-kept-cellsfrom
mokagio/plural-fold-revalidate-validation

Conversation

@mokagio

@mokagio mokagio commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Validation only — do not merge. Stacked on #26263; close once it has answered.

PR CI covers the fix only through unit tests with a synthetic catalog and a stubbed AI tier. No PR job runs download_localized_plurals, which only runs at betas and release finalization.

Read the ":warning: [DO NOT MERGE] Validate plural fold for #26263" job. Every step is expected to pass. It takes the catalog from #26261, because stale cells only exist once the English changes.

  • Input: the catalog has stale %1$ld machine word-count cells, so the checks below can go red.
  • Negative case: with trunk's helper, the real lane keeps all of them and reports no drops.
  • Fix: with this PR's helper, none are left and the lane warns once per dropped cell.
  • No other key loses a cell, and the folded catalog compiles with xcstringstool.

Artifacts: the input catalog, both folded catalogs and both fold logs.

CI can't answer how the real model re-fills the dropped cells: the run has no ANTHROPIC_API_KEY, so they fall back to English. That path is only covered by the unit test with the stubbed translator, and shows at the first beta with the key set.

PR CI runs the fold's unit tests against a synthetic catalog and a stubbed AI tier, never the real `download_localized_plurals` lane against the checked-in translations.

---

Generated with the help of Claude Code (Opus 5.5), https://code.claude.com
@mokagio mokagio self-assigned this Nov 5, 2026
@dangermattic

Copy link
Copy Markdown
Collaborator
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot

Copy link
Copy Markdown
Contributor

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants