Conversation
nicknisi
marked this pull request as ready for review
September 28, 2026 21:08
|
This comment has been minimized.
This comment has been minimized.
The extraction race specs deleted the version/UID-keyed temp cache used by parallel doctor --fix tests. A deletion between materialization and discoverSkills made real refreshWorkOSSkills return null, failing the sibling-protection assertion. Reproduced the exact null failure with a filesystem scheduling barrier in isolated archives of base 2f19926 and AUTH-6733 d8f5a4e (3/3 each). The same barrier passes 3/3 with this fixture isolation; an unchanged baseline still fails. Ordinary paired runs passed 12/12 each, confirming the timing sensitivity rather than relying on a retry until green. Mock only this spec's tmpdir to a unique directory, clean it afterward, and assert it differs from the real shared temp directory. Keep real materialization, allowlist and sibling-write protection assertions unchanged. No production or installer branch behavior changes. (cherry picked from commit c9fd8b6654a206c5c7fc8cc820f15923c5e88c8a)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carry AUTH-6736 forward with scoped CLI fixes and offline Fizzy fixture preparation—not successful hosted Fizzy acceptance.
Acceptance status and blockers
AUTH-6736 remains incomplete until real-app acceptance is proven. No paid agents, live auth/provisioning, or hosted AuthKit acceptance run was executed for this work.
Remaining prerequisites:
The Fizzy acceptance runbook and evidence matrix documents the immutable source pin, isolated preparation, precise remaining prerequisites, and future-run procedure. Source path:
tests/fixtures/ruby/fizzy/README.md.Branch-creation behavior and existing authentication-coexistence decisions are unchanged.
Validation
Local and supervisor checks passed: 3,231 tests, TypeScript, lint, and formatting.
bun run buildalso passed. Offline fixture preparation verified the pinned archive; runtime and hosted acceptance remain unverified.