Repository navigation
Conversation
|
@midenotch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
truthixify
left a comment
There was a problem hiding this comment.
The required snippet job fails before the new crate checks run: removing no-check makes the existing extended checker compile six dependent fragments as standalone rustc files, producing unresolved imports/types. The crate is also a manually duplicated copy rather than being built from or checked against the published fences, so the docs can drift while CI stays green. Make the existing checker pass and add deterministic extraction or a drift assertion tying the crate sources to the documented code.
done,
|
truthixify
left a comment
There was a problem hiding this comment.
Two required snippet jobs remain red on this exact head. The extended Rust job pins Rust/Cargo 1.78 while the resolved base64ct 1.8.3 package requires edition 2024, and Compile docs snippets invokes the missing check:integration-guides package script. Align the toolchain with the committed lockfile, restore the script after the rebase, and rerun all required checks.
9a9f431 to
a8b45ab
Compare
…llar-testnet-snippet-validation-blocking ci(stellar): make testnet snippet validation blocking (wraith-protocol#187)
truthixify
left a comment
There was a problem hiding this comment.
The required extended-snippet workflow is still guaranteed to fail on current head a8b45ab. .github/workflows/snippets.yml:100-104 pins Rust/Cargo 1.78, while the committed lockfile resolves edition-2024 packages (including base64ct 1.8.3 and zeroize_derive 1.5.0). I reproduced the incompatibility with the newer Cargo 1.79: it fails parsing zeroize_derive because edition2024 is not stabilized, so 1.78 cannot build this graph either.
Raise the workflow toolchain to a compatible pinned release (at least 1.85; 1.89 already exists elsewhere in this docs workflow family) or pin a dependency graph compatible with 1.78. The extraction checks, current-toolchain Cargo check/tests (6 tests), and formatting pass locally. This head also conflicts with develop, so GitHub has not exercised the required jobs.
4b4e86d to
8914cc9
Compare
8914cc9 to
364e182
Compare
fixed |
truthixify
left a comment
There was a problem hiding this comment.
Reviewed exact head fb1f71b. The Rust quickstart is tied to the published fences by the extraction/drift checker, the workflow now uses Rust 1.89 for the edition-2024 dependency graph, and every required docs check is green. Local workflow-equivalent Cargo build, network-feature check, formatting, and six unit tests passed.
|
Exact head fb1f71b passed review and the security preflight, and I approved it. PR #205 merged immediately before this merge attempt, so GitHub now reports this branch as conflicting with develop. Please rebase onto the current develop branch while preserving the Rust 1.89 workflow and quickstart drift checks; I will recheck the new head. |
Closes #189
Summary
Related Issue
Type of Change
Changes Made
Testing
Checklist