Repository navigation
Refresh address checks before deployment builds - #686
Open
rossgalloway wants to merge 3 commits into
Open
rossgalloway wants to merge 3 commits into
rossgalloway wants to merge 3 commits into
Conversation
|
Deploy preview for yearn-docs ready!
Deployed with vercel-action |
The address banner used a committed July snapshot because validation ran only after the CI build and outside Vercel's build. Latest-release and missing-entry failures could also leave the overall result green. - Collect a fresh report before production builds and local startup - Publish warning banners for completed mismatches and fail address CI - Stop builds on incomplete checks, including partial RPC failures - Propagate missing-release and gauge-count failures into group results - Preserve legacy getter fallbacks for completed contract observations - Retain CI and scheduled reports as downloadable artifacts - Show the check timestamp on warning banners Validated 30 regression checks, a live mainnet build, workflow parsing, the CI failure step, and the private build preview. Mainnet currently reports 3.1.0 as latest and does not list the documented 3.1.1 release.
rossgalloway
force-pushed
the
ross/address-check-build-reports
branch
from
October 27, 2026 16:29
249a454 to
ecd2d86
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The address banner kept showing a July snapshot because checks ran after the CI build and outside Vercel's build. Some recorded failures also left the result green. Builds now collect a fresh report before rendering, publish a warning banner for completed mismatches, and stop when checks cannot complete.
#685 has merged. This PR targets
masterand includes the resolved package-script conflict, preserving both NatSpec and address-check tests.How to review
scripts/withAddressChecks.tsand the package scripts. Bothbuildandstartcollect and validate a fresh report before proceeding.build:siteremains an explicit way to render an existing snapshot.scripts/runAddressChecks.tsandscripts/addressCheckReport.ts. Exit 0 means passed, exit 1 means completed with mismatches, and exit 2 means incomplete. A checker crash cannot reuse a previous green report.The checked-in snapshot records the earlier registry discrepancy. Live checks on October 27 now report 3.1.1 as latest, with all V3, veYFI, and multisig checks passing and no mismatches. Both documentation CI runs passed after rerunning against the updated registry. Deployment builds always collect their own fresh report.
Test plan
bun run test:natspec— all 8 checks passed after mergingmaster.bun run test:addresses— 30 regression checks passed, including partial RPC failures, legacy getter fallbacks, incomplete reports, and development startup with warning data.RPC_URI_FOR_1=https://rpc.yearn.fi/chain/1 bun run build— collected live mainnet results before a successful website build and AI exports.Reran both documentation CI jobs on October 27; the live address checks, regression tests, site build, and CI result step all passed. Verified the retained report has all three check groups passing and no failed checks.
Parsed both updated GitHub Actions workflows.
Verified the October 27 preview shows a fresh passing banner after the registry update.
git diff --checkpassed.GitHub Markdown link lint and Vercel deployment passed at
249a4544e.All GitHub checks passed at
249a4544eafter the registry update and CI reruns.Risk / impact
Builds now require mainnet RPC availability. Completed mismatches publish a fresh warning page, while unavailable or incomplete reads stop the build. Future mismatches will fail address-check CI while allowing the separate Vercel preview workflow to publish the completed warning report. All validation is read-only. Reverting this PR restores the previous build and checking behavior.