Spec: unified MEMMOVE accelerator - #986
Open
nicole-graus wants to merge 4 commits into
Open
Conversation
Kimi Code ReviewAutomated review by Kimi (Moonshot AI) |
Codex Code Review
|
nicole-graus
marked this pull request as ready for review
September 11, 2026 15:53
Kimi Code ReviewAutomated review by Kimi (Moonshot AI) |
Codex Code Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Specifies the accelerator implemented in #984.
MEMMOVEchapter coveringmemcpy,memmove,memsetandcommit. The destination domain and the read/write timestamp order are decoded from the entry point, never chosen by the caller:is_setfrom the syscall number,is_commitfrom which bus the first row accepted from, both carried insideMEMMOVE_NEXTso a sequence cannot change functionality midway.COMMITis now one row per ecall: it keeps the syscall number and thex254update, and defers the byte loop overCOMMIT_DEFER.CNBis retired.ADDNWtemplate, which is what rules out a sequence closing into a ring.-30(copy) and-32(memset), and lists-31as reserved forHINTso it is not handed out twice.