Run card tests unmount what they draw - #48
Merged
Merged
Conversation
RunChat's and ConversationWorking's tests left their drawn cards mounted, so the now line's dwell, its words' fade and the bars' clocks kept firing after the file ended: five timers left in RunChat's, two in ConversationWorking's. A late render logged while the worker closed and failed main's Test job (EnvironmentTeardownError on onUserConsoleLog). Each test's cards are now unmounted after it, and no timer of theirs outlives the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's CI Test job failed after pass 26 merged: every test passed, but Vitest caught an unhandled error, "Closing rpc while 'onUserConsoleLog' was pending", traced to
RunChat.test.tsx.That test file and
ConversationWorking.test.tsxnever unmounted the cards they drew. The run card's new timers (the now line's 1 s dwell, the words' fade, the clock) kept running after the files ended, and a late render logged while the worker was closing.Each card a test draws is now unmounted after the test, which clears its timers. The console is not silenced. 25 repeated runs of the affected files and the whole
src/components/chatfolder show no unhandled errors.🤖 Generated with Claude Code