Skip to content

A message echoed in the run card shows its words and its pictures - #55

Merged
fxck merged 1 commit into
mainfrom
fix/card-echo-pictures
Oct 1, 2026
Merged

fxck merged 1 commit into
mainfrom
fix/card-echo-pictures

Conversation

@fxck

@fxck fxck commented Oct 1, 2026

Copy link
Copy Markdown
Member

Inside a working run card, a message the person sent during the run showed as just "[Picture 1]" when it held a picture. Its words were dropped and the picture never drawn.

Cause. PersonMark (RunChat.tsx) shows the first line of the message's text. A message with a picture starts with its [Picture 1] label line.

Fix. The echo stays one line, as decided on 2026-09-28. That line is now the first line of the person's words, never a picture label. A compact strip of thumbnails sits under it, in the timeline's order, and each thumbnail opens the viewer. A picture-only message shows just the strip. echoOfMessage reuses the timeline's own picture placement (messagePictures.logic.ts).

Tests: a 6-case logic table, the one-line test adapted to "the first line of words, never a label", and a picture render test.

🤖 Generated with Claude Code

@fxck
fxck force-pushed the fix/card-echo-pictures branch from ed241c9 to 8bee2cb Compare October 1, 2026 10:24
…s words and its pictures

The card's echo of a message the person sent into a run showed the first line of its text. A
message holding a picture starts with its [Picture 1] label line, so the echo read just the label:
the words were dropped and the picture never drawn. The echo stays one line, now the first line of
the words, never a label, with a compact strip of thumbnails under it in the timeline's order;
each opens the viewer, and a picture-only message shows just the strip.
@fxck
fxck force-pushed the fix/card-echo-pictures branch from 8bee2cb to f3f78f7 Compare October 1, 2026 10:24
@fxck
fxck merged commit 3d9be8b into main Oct 1, 2026
11 checks passed
fxck added a commit that referenced this pull request Oct 1, 2026
- #50 A person's own new project never waits on the path for someone else's
- #51 A docked operation offers to open only when opening adds something
- #52 A change's review reads the change itself, and rows name their repository when a Mate has two
- #54 A coming-up Mate's page hands over as soon as the Mate answers, whatever the browser kept
- #53 The account's line: Try now shows it tries, names what isn't answering, and one org's trouble holds no other
- #56 The composer's top lists every change that waits for review
- #55 A message echoed in the run card shows its words and its pictures
- #57 One stalled subscription retries alone instead of replacing the organization's socket
- #58 Docs: what the hours after 0.11.74 measured, and the fixes they took
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant