Repository navigation
[Modelica] Modernize vehicle assemblies and mirrored fixtures - #33
Closed
rhorvath02 wants to merge 1 commit into
Closed
rhorvath02 wants to merge 1 commit into
rhorvath02 wants to merge 1 commit into
Conversation
This was referenced Oct 22, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old chassis/axle/template hierarchy duplicated assembly choices and mixed calibration, connectors and implementation details. This change migrates the Modelica library to typed VI-derived subsystem contracts, nested owner records and constrained replaceable assemblies, with matching Modelica fixtures.
Includes explicit brake reaction paths and halfshafts, subsystem-owned mounts, wheel compliance, single-axle KnC rigs, package/icon cleanup and diagram routing. Public class paths and record modifiers change. The library migration and its callers stay together because a directory-only split leaves unresolved contracts and class paths.
Scope is the preserved pre-SS release candidate, with a formatting-only MassRecord correction. Python native/FMU tooling, SS/GGV models and SS initialization hooks are excluded. Later GGV-related plant edits are held separately. Existing VehicleFMI and the dynamic steady maneuver remain.
Validation: six standard entry points passed checkModel with balanced equations using OMC 1.27.1/MSL 4.1.0/VI 2.0.2; full-tree Modelica formatting passed. Modelica fixtures accompany the migration; the next PR adds the expanded Python regression harness.
Draft: full simulations and exhaustive OMEdit acceptance have not been rerun for this extracted revision. Existing #30 and #31 need reconciliation with the changed package/record paths; neither is modified by this stack.
Stack (merge bottom-up):