Skip to content

[Calibration] Introduce nested subsystem record contracts - #38

Merged
rhorvath02 merged 2 commits into
review/boblib-packagesfrom
review/boblib-calibration
Oct 25, 2026
Merged

rhorvath02 merged 2 commits into
review/boblib-packagesfrom
review/boblib-calibration

Conversation

@rhorvath02

@rhorvath02 rhorvath02 commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Purpose

Give each subsystem one physical calibration record instead of repeating unrelated scalar parameters across assemblies.

Approach

Add nested records for chassis, frames, axles, wheels, brakes, halfshafts and differentials, plus engine/transmission records. Preserve derived mass-property relationships and keep architecture choices separate from calibration.

Validation

Record references, package entries and Modelica formatting checked. Existing vehicle constructors remain usable at this stage.

@raorjun raorjun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two new record defaults turn required calibration into silent zeros. A record that omits these fields now translates and runs with wrong physics.

Comment thread BobLib/Records/VehicleRecord/Chassis/FrameRecord.mo Outdated
Comment thread BobLib/Records/VehicleRecord/Chassis/Suspension/WheelRecord.mo Outdated
Remove the zero defaults from FrameRecord.driverMass and WheelRecord.vertical. A record that omits them now fails at translation instead of silently dropping driver mass or tire stiffness.
@raorjun

raorjun commented Oct 23, 2026

Copy link
Copy Markdown
Member

Fixed in 010c2a5. driverMass and the wheel vertical calibration have no default now, so a record that omits them fails at translation. All 9 VehicleDefn records already set both. Six test fixtures did not, so they now set the values explicitly: TestWheelPhysicsVariants in 8b229a9 (#43), and TestFrameRigid, TestFrameCompX, TestFourMF52Kinematic, TestFourMF52Transient and TireForceFrameSmoke in 39ffd9c (#48). Rigs with no driver set m = 0 explicitly. VehicleSim, FourPostSim, KnCLocked, KnCSteerable and VehicleFMI translate at the stack tip.

@raorjun raorjun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. CI is green, and the review findings are fixed or addressed in the comments above.

@rhorvath02
rhorvath02 merged commit c563786 into main Oct 25, 2026
3 checks passed
@rhorvath02
rhorvath02 deleted the review/boblib-calibration branch October 25, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-assisted Developed with AI agent assistance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants