Repository navigation
[Calibration] Introduce nested subsystem record contracts - #38
Conversation
raorjun
left a comment
There was a problem hiding this comment.
Two new record defaults turn required calibration into silent zeros. A record that omits these fields now translates and runs with wrong physics.
Remove the zero defaults from FrameRecord.driverMass and WheelRecord.vertical. A record that omits them now fails at translation instead of silently dropping driver mass or tire stiffness.
|
Fixed in 010c2a5. |
raorjun
left a comment
There was a problem hiding this comment.
Approve. CI is green, and the review findings are fixed or addressed in the comments above.
Purpose
Give each subsystem one physical calibration record instead of repeating unrelated scalar parameters across assemblies.
Approach
Add nested records for chassis, frames, axles, wheels, brakes, halfshafts and differentials, plus engine/transmission records. Preserve derived mass-property relationships and keep architecture choices separate from calibration.
Validation
Record references, package entries and Modelica formatting checked. Existing vehicle constructors remain usable at this stage.