Repository navigation
[Interfaces] Declare subsystem-owned control buses - #39
Merged
Merged
Conversation
This was referenced Oct 22, 2026
rhorvath02
marked this pull request as ready for review
October 22, 2026 06:10
raorjun
approved these changes
Oct 23, 2026
raorjun
left a comment
raorjun
left a comment
Member
There was a problem hiding this comment.
Approve. CI is green, and the review findings are fixed or addressed in the comments above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Make each subsystem's published measurements and commands explicit in its bus contract.
Approach
Add domain-owned typed buses and
BobLib.Utilities.Interfaces.ControlBus, following VehicleInterfaces conventions. Include an axle bus for suspension measurements and omit unused subsystem buses from the aggregate contract.Validation
Connector declarations, package references and Modelica formatting checked. Adapter adoption is separate from these bus definitions.