Repository navigation
[Electrical] Give battery, inverter and motor independent record-based contracts - #47
Merged
Merged
Conversation
This was referenced Oct 22, 2026
rhorvath02
marked this pull request as ready for review
October 22, 2026 06:10
rhorvath02
force-pushed
the
review/boblib-electrical
branch
from
October 22, 2026 07:07
b327e0a to
a30abe6
Compare
rhorvath02
force-pushed
the
review/boblib-electrical
branch
from
October 22, 2026 08:44
a30abe6 to
66e1a1b
Compare
raorjun
approved these changes
Oct 23, 2026
raorjun
left a comment
raorjun
left a comment
Member
There was a problem hiding this comment.
Approve. CI is green, and the review findings are fixed or addressed in the comments above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
#32
Purpose
Make the battery, inverter and motor independently balanced, record-configured components.
Approach
The inverter supplies voltage and allocated power; the motor owns its current law. Add owner-named records, typed adapter contracts and updated callers. Align exported event hysteresis with integration tolerance and prefer the motor's existing rotor speed as a state to prevent CVODE stalls at direction events.
Validation
The unchanged FMU regression suite passes locally and in GitHub x86 CI: six passed, with the existing re-launch expected failure retained at this layer. The final stack passes all seven locally. Fresh initialization comparisons found identical shared physical values; four affected snapshots track the selected rotor-state names. Modelica formatting and parameter documentation checks pass. GitHub CI passes all three jobs.